<DIV>> To me, that seems pretty bad user interface.</DIV>
<DIV>> </DIV>
<DIV>> The client should make this easier. Eg, I control right click on object (or </DIV>
<DIV>> some other combo of unused mouseclick/keypress) to rename an object. The client </DIV>
<DIV>> can then send a command like 'rename <OBJECT_TAG><NEW_NAME>', and the server </DIV>
<DIV>> then looks for an object of object_tag in the players inventory to rename, and </DIV>
<DIV>> does so with new name.</DIV>
<DIV> </DIV>
<DIV>Well i didn't want to mess with the client.... for a start i didn't yet try to compile it under win32, didn't even install gtk-dev as a matter of fact....</DIV>
<DIV> </DIV>
<DIV>also we could imagine having both control-rightclick in client and the 'rename command (as far as i know, the only thing you can't do easily without the mouse is object locking/unlocking)</DIV>
<DIV>that would also mean doing a dialog box to ask for the new name</DIV>
<DIV> </DIV>
<DIV>it's imo easier to first implement 'basic' rename with a simple interface, then add a custom client implementation like control-click. which would just use that rename function (like the apply works, right?) </DIV>
<DIV> </DIV>
<DIV>> Also, your rename function is dangerous:</DIV>
<DIV><snip></DIV>
<DIV>> since 'params' is user supplied data, very easy for the user to provide data </DIV>
<DIV>> that would cause buffer overruns.</DIV>
<DIV> </DIV>
<DIV>true, didn't think about that. My mistake.</DIV>
<DIV>(on the other hand the client, at least gtk, too has buffer overruns issues sometimes... try to bind a key to a hundred 'use_skill praying' :-))</DIV>
<DIV> </DIV>
<DIV>> You should really use new_draw_info_format. Then you don't even need to </DIV>
<DIV>> declare buf in that function.</DIV>
<DIV> </DIV>
<DIV>Ha, copied some part of other code which still uses the new_draw_info....</DIV>
<DIV> </DIV>
<DIV>> I disagree with that actually. It seems to me that if I rename something, I </DIV>
<DIV>> really consider that name important.</DIV>
<DIV>> </DIV>
<DIV>> If a player renames something and in ends up conflicting with other items, </DIV>
<DIV>> that is his problem. But If I call my haggises wine, then whever I use any </DIV>
<DIV>> string to options to adjust that item, if I use wine, it should match the </DIV>
<DIV>> haggises, which I've specifically renamed to be called that, and not a generic </DIV>
<DIV>> object.</DIV>
<DIV>> </DIV>
<DIV>> This is unlikely to come up, but it just doesn't seem right to me to treat an </DIV>
<DIV>> object the player has renamed as the lowest value in matching order.</DIV>
<DIV> </DIV>
<DIV>I too agree that is unlikely to come up. But that case must be solved clearly, to not depend on item order in inventory.</DIV>
<DIV>So let's either give more precedence, or give less :-)</DIV>
<DIV>Guess that's something to be decided collectively</DIV>
<br><br>
Accédez au courrier électronique de La Poste : www.laposte.net ;
<br>
3615 LAPOSTENET (0,34€/mn) ; tél : 08 92 68 13 50 (0,34€/mn)